Skip to content

fix(lint): skip tests and scripts - #16663

Merged
mattsse merged 2 commits into
masterfrom
fig/lint-test-script-exclusions
Sep 5, 2026
Merged

fix(lint): skip tests and scripts#16663
mattsse merged 2 commits into
masterfrom
fig/lint-test-script-exclusions

Conversation

@figtracer

@figtracer figtracer commented Sep 5, 2026

Copy link
Copy Markdown
Member

Skip lint diagnostics in configured test and script directories, including explicitly selected lints, while retaining unsafe-cheatcode under its existing severity, exclusion, and suppression rules. This removes noise from helper initializers such as address bob = makeAddr("bob") and events emitted as vm.expectEmit expectations. Production sources remain linted, including sources inherited by tests.

Fixes #16659 and fixes #16662.

Suppress lint noise in configured test and script directories while retaining unsafe-cheatcode checks under existing selection rules.
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

✅ Changelog found

The deterministic check will validate the changed entry.

Cover issue #16662 by checking that expectation emits stay silent in tests and scripts while the same sequence is still diagnosed in production sources.
@mattsse
mattsse merged commit 4882b87 into master Sep 5, 2026
32 checks passed
@mattsse
mattsse deleted the fig/lint-test-script-exclusions branch September 5, 2026 02:05
@github-project-automation github-project-automation Bot moved this to Done in Foundry Sep 5, 2026
@mablr mablr mentioned this pull request Sep 5, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

lint: 'reentrancy-events' flags on vm.expectEmit lint: function-init-state flags makeAddr

2 participants